Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kona guide #1223

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Kona guide #1223

wants to merge 7 commits into from

Conversation

krofax
Copy link
Contributor

@krofax krofax commented Jan 6, 2025

Description

This is an high level guide to Kona, an alternative fault-proof program for the OP Stack.

Tests

Additional context

Metadata

@krofax krofax requested a review from a team as a code owner January 6, 2025 16:08
Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit c3b7a12
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/677c19fddc5b9200084fc017
😎 Deploy Preview https://deploy-preview-1223--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Jan 6, 2025

📝 Walkthrough

Walkthrough

This pull request introduces documentation updates across multiple files in the Optimism documentation repository. The changes primarily focus on two main aspects: renaming "Further reading" sections to "Next steps" in various documentation files, and adding documentation for the new Kona Fault Proof Virtual Machine (FPVM). A new page for Kona has been created in the fault proofs section, providing detailed information about its implementation, architecture, and role in the OP Stack ecosystem. Additionally, the words.txt file has been updated with new terms related to the Kona and Asterisc fault proof systems. The modifications aim to improve documentation clarity and provide more comprehensive information about the latest developments in the Optimism fault proof infrastructure.

Sequence Diagram

sequenceDiagram
    participant User
    participant Docs
    participant Kona FPVM
    participant Asterisc FPVM

    User->>Docs: Access Fault Proofs Documentation
    Docs->>User: Display Kona FPVM Information
    User->>Kona FPVM: Explore Implementation Details
    Kona FPVM-->>User: Provide Step-by-Step Execution Info
    User->>Asterisc FPVM: Compare Implementations
    Asterisc FPVM-->>User: Show Architectural Differences
Loading

Possibly related PRs

Suggested labels

flag:merge-pending-release

Suggested reviewers

  • sbvegan
  • bradleycamacho
  • hamdiallam

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5168f74 and c3b7a12.

📒 Files selected for processing (2)
  • pages/stack/fault-proofs/explainer.mdx (1 hunks)
  • pages/stack/fault-proofs/kona.mdx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pages/stack/fault-proofs/explainer.mdx
🧰 Additional context used
📓 Path-based instructions (1)
pages/stack/fault-proofs/kona.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
  • GitHub Check: pr-workflow
🔇 Additional comments (15)
pages/stack/fault-proofs/kona.mdx (15)

1-6: LGTM! Frontmatter is well-structured

The frontmatter follows the documentation guidelines with proper capitalization and formatting.


8-11: LGTM! Clear and informative introduction

The title and introduction effectively establish Kona's role in the OP Stack ecosystem.


13-13: Use sentence case for section header

According to the documentation guidelines, H2 headers should use sentence case.

-## Overview
+## Overview

15-23: LGTM! Well-structured overview section

The overview effectively explains Kona's operation and key features.


33-33: Fix broken documentation link

The link to the Asterisc documentation appears to be broken.

-For more on Asterisc, see the [Asterisc documentation](./asterisc.mdx).
+For more on Asterisc, see the [Asterisc documentation](./asterisc).

37-37: Use sentence case for section headers

According to the documentation guidelines, headers should use sentence case while preserving proper nouns.

-## Key differences
+## Key differences

-### Architecture
+### Architecture

-### Performance
+### Performance

Also applies to: 39-39, 46-46


41-50: LGTM! Clear comparison of systems

The comparison table and performance points effectively highlight the differences between systems.


51-51: Use sentence case for section header

According to the documentation guidelines, H2 headers should use sentence case.

-## Getting Started
+## Getting started

53-82: LGTM! Clear setup instructions

The step-by-step instructions are well-organized and include appropriate code examples.


83-83: Use sentence case for section header

According to the documentation guidelines, H2 headers should use sentence case while preserving proper nouns.

-## Benefits of Kona
+## Benefits of Kona

85-93: LGTM! Well-structured benefits section

The benefits are clearly presented and well-explained.


94-94: Use sentence case for section header

According to the documentation guidelines, H2 headers should use sentence case.

-## Limitations
+## Limitations

96-99: LGTM! Clear explanation of limitations

The limitations are transparently communicated with appropriate context.


100-100: Use sentence case for section header

According to the documentation guidelines, H2 headers should use sentence case.

-## Next steps
+## Next steps

102-106: LGTM! Comprehensive resource links

The next steps section provides relevant links to additional resources.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 7

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b40b78 and 5168f74.

📒 Files selected for processing (9)
  • pages/chain/identity/individuals.mdx (1 hunks)
  • pages/chain/identity/projects.mdx (1 hunks)
  • pages/stack/fault-proofs.mdx (1 hunks)
  • pages/stack/fault-proofs/_meta.json (1 hunks)
  • pages/stack/fault-proofs/cannon.mdx (2 hunks)
  • pages/stack/fault-proofs/explainer.mdx (1 hunks)
  • pages/stack/fault-proofs/kona.mdx (1 hunks)
  • pages/stack/fault-proofs/mips.mdx (1 hunks)
  • words.txt (7 hunks)
✅ Files skipped from review due to trivial changes (5)
  • pages/stack/fault-proofs/_meta.json
  • pages/chain/identity/projects.mdx
  • pages/stack/fault-proofs/mips.mdx
  • pages/stack/fault-proofs/cannon.mdx
  • pages/chain/identity/individuals.mdx
🧰 Additional context used
📓 Path-based instructions (3)
pages/stack/fault-proofs/explainer.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
pages/stack/fault-proofs.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
pages/stack/fault-proofs/kona.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
🪛 LanguageTool
pages/stack/fault-proofs/explainer.mdx

[style] ~108-~108: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...plainer guide on cannon. * Read about the [components of the fault proo...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

🔇 Additional comments (1)
words.txt (1)

13-13: LGTM!

The new terms are properly capitalized and alphabetically sorted.

Also applies to: 16-16, 155-155, 177-177, 207-207, 305-305, 341-341, 417-417

pages/stack/fault-proofs/explainer.mdx Outdated Show resolved Hide resolved
pages/stack/fault-proofs/explainer.mdx Outdated Show resolved Hide resolved
pages/stack/fault-proofs.mdx Show resolved Hide resolved
pages/stack/fault-proofs/kona.mdx Show resolved Hide resolved
pages/stack/fault-proofs/kona.mdx Outdated Show resolved Hide resolved
pages/stack/fault-proofs/kona.mdx Outdated Show resolved Hide resolved
pages/stack/fault-proofs/kona.mdx Show resolved Hide resolved
krofax and others added 4 commits January 6, 2025 17:19
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@krofax krofax changed the title Kona Guide Kona guide Jan 6, 2025
@krofax krofax requested a review from pauldowman January 17, 2025 14:07
@@ -8,11 +8,13 @@ import { Card, Cards } from 'nextra/components'

# Fault Proofs

Documentation covering Cannon, Challenger, Explainer, Fp Components, Fp Security, Mips in the Fault Proofs section of the OP Stack ecosystem.
Documentation covering Cannon, Kano Challenger, Explainer, Fp Components, Fp Security, Mips in the Fault Proofs section of the OP Stack ecosystem.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the typo introduced here, this sentence really needs an overhaul, it doesn't make much sense.

How about: "Documentation covering the Fault Proof system including Cannon, OP-Challenger, Asterisc, and Kona."


<Cards>
<Card title="Fault proof VM - Cannon" href="/stack/fault-proofs/cannon" />

<Card title="Fault proof VM - Kano" href="/stack/fault-proofs/kona" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Typo: "Kano"
  2. Kona isn't a fault proof VM, it's a fault proof program (equivalent to op-program). Asterisc is the fault proof VM (equivalent to Cannon). So if we have an equivalent to the "Fault proof VM - Cannon" page, it would be ""Fault proof VM - Asterisc"

@@ -2,6 +2,7 @@
"explainer": "Fault proofs explainer",
"fp-components": "FP system components",
"cannon": "FPVM: Cannon",
"kona": "FPVM: Kona",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the comment above, the fault proof VM is Asterisc (not Kona).

See the [specs](https://specs.optimism.io/experimental/fault-proof/stage-one/bond-incentives.html) for more details.
## Next steps

* For more info about how fault proofs works under the hood,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* For more info about how fault proofs works under the hood,
* For more info about how fault proofs work under the hood,

@@ -0,0 +1,106 @@
---
title: "Fault proof VM - Kona"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above the fault proof VM is Asterisc. So if this page is the equivalent of the Cannon page then it should be "Fault proof VM - Asterisc".

Copy link
Contributor

@pauldowman pauldowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left a bunch of inline comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants